Events API Send-RSVP support #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrashed-dev
suggested changes
Dec 11, 2023
Comment on lines
5
to
16
| /** | ||
| * Enum representing the allowed RSVP status values. | ||
| */ | ||
| enum class RsvpStatus(val value: String) { | ||
| YES("yes"), | ||
| NO("no"), | ||
| MAYBE("maybe"); | ||
|
|
||
| override fun toString(): String { | ||
| return value | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we move this to its own file?
| * @return The send-rsvp response | ||
| */ | ||
| @Throws(NylasApiError::class, NylasSdkTimeoutError::class) | ||
| fun sendRsvp(identifier: String, requestBody: SendRsvpRequest, queryParams: SendRsvpQueryParams): Response<Event> { |
There was a problem hiding this comment.
I believe the response type should be a model that represents a send rsvp response. According to the docs it should be an object like:
{
request_id: string
}
|
@mrashed-dev Thanks for the review! The changes are made based on the request. The |
mrashed-dev
approved these changes
Dec 18, 2023
Merged
mrashed-dev
added a commit
that referenced
this pull request
Dec 18, 2023
# Changelog ### Added * Added support for event send RSVP (#175) ### Changed * Fixed int type being serialized to double sometimes (#177) * Fixed `Auth.exchangeCodeForToken` always returning 401 (#178) * Fixed error when sending message or updating draft (#179) # License <!-- Your PR comment must contain the following line for us to merge the PR. --> I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.